Bsb/new notebooks fix key issues #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riferrei
requested changes
Apr 29, 2025
|
This one fails during compilation for the highlighted dependency. 
|
|
And this one fails during runtime when you specify the user. Note that, maybe this was due to the fact that I changed the model from Anthropic to OpenAI. Maybe this influences the internal behavior of LangGraph. 
|
|
Also, your Docker Compose maybe be binding to a particular folder of the filesystem that avoids the execution to start. 
|
bsbodden
force-pushed
the
bsb/new-notebooks-fix-key-issues
branch
from
115c145 to
8084a03
Compare
Core changes: - Fix Redis key parsing to handle additional components in _parse_redis_checkpoint_writes_key method - Modify error handling to accept keys with more than 6 components by slicing (parts[:6]) - Update error message to indicate "at least 6 parts" needed rather than "expected 6" Added comprehensive test suites: - Basic key parsing tests (test_key_parsing.py) - Subgraph key parsing tests (test_subgraph_key_parsing.py) - Fix verification tests (test_fix_verification.py) - Semantic search key tests (test_semantic_search_keys.py) - Streaming tests (test_streaming_modes.py, test_streaming.py) Added new example notebooks: - Memory management examples (add-summary-conversation-history, delete-messages, etc.) - Human-in-the-loop examples (breakpoints, edit-graph-state, time-travel, etc.) - Subgraph management notebooks (subgraph-persistence, subgraphs-manage-state) - Agent creation examples with history management and HITL
bsbodden
force-pushed
the
bsb/new-notebooks-fix-key-issues
branch
from
8084a03 to
e458d19
Compare
abrookins
reviewed
Apr 30, 2025
| pipeline = self._redis.pipeline(transaction=True) | ||
|
|
||
| # Store minimal checkpoint data | ||
| checkpoint_data = { |
abrookins
reviewed
Apr 30, 2025
| @@ -0,0 +1,88 @@ | |||
| """Focused test for Redis key parsing fix. | |||
There was a problem hiding this comment.
Excellent testing as usual
abrookins
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@riferrei discovered that I have committed the wrong version of the notebooks (the original LangGraph non-Redis ones) - This PR addresses that, but also, as I added several new notebooks testing advanced scenarios, I discovered some issues, mainly key construction and parsing, most of which surfaced when working with subgraphs.
This PR brings the number of notebooks to 20