Skip to content

Query and Search Basic Examples #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shacharPash
Copy link
Contributor

Closes #109

@shacharPash shacharPash changed the title Issue109/query and search basic Query and Search Basic Examples Apr 17, 2023
@shacharPash shacharPash requested review from uglide and a team April 17, 2023 12:47
@shacharPash shacharPash added the documentation Improvements or additions to documentation label Apr 17, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (26036f2) 93.27% compared to head (56f2f4d) 93.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files          77       77           
  Lines        4582     4582           
  Branches      424      424           
=======================================
  Hits         4274     4274           
  Misses        186      186           
  Partials      122      122           
Impacted Files Coverage Δ
src/NRedisStack/Search/SearchResult.cs 92.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* start working

* using StringBuilder

* Change to List<string>

* finish test

* using HashSet

* add sleep to failed search test

* comment problematic assert

* change to Assert.Equal

* Assert.Equal(expectedResSet, resSet);

* change vec 4 to 5 inorder to make result deterministic
@shacharPash shacharPash changed the base branch from master to Issue108/AdvancedJsonExamples April 23, 2023 10:15
@shacharPash shacharPash merged commit 4144046 into Issue108/AdvancedJsonExamples Apr 23, 2023
@shacharPash shacharPash deleted the Issue109/QueryAndSearchBasic branch April 23, 2023 10:17
shacharPash added a commit that referenced this pull request Apr 23, 2023
* adding basic json example

* finish BasicJsonExamplesTest

* fix test

* Remove Unnecessary usings

* start adding AdvancedJsonExamples

* add to Newtonsoft.Json csproj

* finish test

* last fixes

* Update ExamplesTests.cs

* Delete "Lab 4 - "

* Query and Search Basic Examples (#113)

* add Basic Query Operations Exampele

* fix error

* fix order error

* remove unused usings

* add sleep

* Query and Search Advanced Examples (#115)

* start working

* using StringBuilder

* Change to List<string>

* finish test

* using HashSet

* add sleep to failed search test

* comment problematic assert

* change to Assert.Equal

* Assert.Equal(expectedResSet, resSet);

* change vec 4 to 5 inorder to make result deterministic

* last fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query and Search basic
2 participants