-
Notifications
You must be signed in to change notification settings - Fork 46
Support JSON.MSET Command #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ac44147
Support JSON.MSET Command
shacharPash bd52427
add tests
shacharPash bc635e4
Merge branch 'master' into Issue128/JSON.MSET
shacharPash 3936612
fixes
shacharPash ed2751f
adding edge filter
slorello89 fd16eeb
bump
slorello89 eabd24d
applying to .NET 6 too
slorello89 f2ccf86
think it might be picking up the version env var
slorello89 7258335
Merge branch 'master' into Issue128/JSON.MSET
shacharPash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
using System.Text.Json; | ||
|
||
namespace NRedisStack.Json.DataTypes; | ||
|
||
public struct KeyValuePath | ||
{ | ||
public string Key { get; set; } | ||
public object Value { get; set; } | ||
public string Path { get; set; } | ||
|
||
public KeyValuePath(string key, object value, string path = "$") | ||
{ | ||
if (key == null || value == null) | ||
{ | ||
throw new ArgumentNullException("Key and value cannot be null."); | ||
} | ||
|
||
Key = key; | ||
Value = value; | ||
Path = path; | ||
} | ||
public string[] ToArray() | ||
{ | ||
if (Value is string) | ||
{ | ||
return new string[] { Key, Path, Value.ToString() }; | ||
} | ||
return new string[] { Key, Path, JsonSerializer.Serialize(Value) }; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. We'll remove this once it hits a versioned docker. Similar to the skipif in other tests for other clients.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in docker & the main ubuntu package - the windows image downloads the tarball directly and installs it in WSL.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a skip attribute that lets you skip a test you don't want to run, but it doesn't permit conditionals unfortunately, there are ways to setup some conditionals to override the behavior (several OSS projects do something of the like) but that's kind of overkill for something that needs a relatively simple filter like this.