mark TOPK.COUNT as deprecated #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #21 |
chayim
reviewed
Dec 29, 2022
| long[] Count(RedisKey key, params RedisValue[] items); | ||
|
|
||
| /// <inheritdoc cref="Count(RedisKey, RedisValue[])"/> | ||
| [Obsolete("TOPK.COUNT is deprecated since Bloom 2.4.0")] |
There was a problem hiding this comment.
instead of 'since' use as of
chayim
reviewed
Dec 29, 2022
| @@ -24,9 +24,11 @@ public interface ITopKCommands | |||
| /// <param name="item">Items to be counted.</param> | |||
| /// <returns>count for responding item.</returns> | |||
| /// <remarks><seealso href="https://redis.io/commands/cf.count"/></remarks> | |||
| [Obsolete("TOPK.COUNT is deprecated since Bloom 2.4.0")] | |||
There was a problem hiding this comment.
instead of 'since' use as of
Codecov ReportBase: 68.38% // Head: 68.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 67 67
Lines 4659 4659
Branches 446 446
=======================================
Hits 3186 3186
Misses 1278 1278
Partials 195 195 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
chayim
approved these changes
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.