Support iteration for SCAN, FT.SEARCH, FT.AGGREGATE commands #3378
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3378 +/- ##
============================================
+ Coverage 67.29% 67.30% +0.01%
- Complexity 4716 4723 +7
============================================
Files 269 269
Lines 15232 15239 +7
Branches 963 963
============================================
+ Hits 10250 10257 +7
+ Misses 4564 4563 -1
- Partials 418 419 +1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@bsbodden @maorohana-redis Please check. |
|
|
||
| public class FtAggregateRoundRobin extends JedisRoundRobinBase<AggregationResult> { | ||
| public class FtAggregateIteration extends JedisCommandIterationBase<AggregationResult, Row> { |
There was a problem hiding this comment.
@bsbodden @maorohana-redis Also let me know whether you prefer Row or Map<String, Object> for aggregation replies.
There was a problem hiding this comment.
I like the concept of Row since you could also pack any metadata about its results. Like in VSS for example, the score could come as part of Row but let's hear from Maor too.
No description provided.