Fix flaky test JedisPoolTest.testCloseConnectionOnMakeObject

[thachlp]

The test JedisPoolTest.testCloseConnectionOnMakeObject occasionally fails with the following error:

`JedisPoolTest.testCloseConnectionOnMakeObject:403 expected:<4> but was:<5>`

Root Cause:
The assertion is based on the output of getClientCount(jedis.clientList()), which is called immediately after closing a connection. However, Redis may take a short time to remove the closed connection from the client list, leading to a transient count mismatch and a flaky test result.

Example stack trace:

Error:  redis.clients.jedis.JedisPoolTest.testCloseConnectionOnMakeObject -- Time elapsed: 0.006 s <<< FAILURE!
java.lang.AssertionError: expected:<4> but was:<5>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at redis.clients.jedis.JedisPoolTest.testCloseConnectionOnMakeObject(JedisPoolTest.java:403)

closes #4135

[ggivo]

@thachlp
Thanks for looking into the issue!
I think using Awaitility would simplify things.

[thachlp]

Thank @thachlp for helping me update the description.
Btw, I tried to run format and validate and it was successful, but it still fail on check-format job.
What do I miss? 🙇

[ggivo]

Thank @thachlp for helping me update the description. Btw, I tried to run format and validate and it was successful, but it still fail on check-format job. What do I miss? 🙇

Since code formatting was not enforced there are lots of discrepancies in the code. We are currently experimenting with how to enforce it. [Java Format Check] is optional currently and serves as a hint to reviewers that the code is not properly formatted. You can discard it for now. In case formatting the whole file introduces lots of additional formatting changes and makes the review harder my advice is to format only the modified code. Code formatting rules can be found hbase-formatter.xml.

PS: mvn formatter:format will reformat only sources described here
https://github.com/ggivo/jedis/blob/a4d2b8d062a3ecb878750f83abe0439f01100739/pom.xml#L329-L329

[ggivo]

LGTM