Skip to content

Use setuptools setup.cfg declarative configuration #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Use setuptools setup.cfg declarative configuration #1316

merged 1 commit into from
Apr 9, 2020

Conversation

jdufresne
Copy link
Contributor

For details on this feature, see:
https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files

Setuptools allows using setup.cfg as a configuration file to define the
package metadata and options. This approach reduces boilerplate code in
favor of a declarative configuration. Down the road, this approach also
allows for automation through scripts and tools.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? (N/A)

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

For details on this feature, see:
https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files

Setuptools allows using setup.cfg as a configuration file to define the
package metadata and options. This approach reduces boilerplate code in
favor of a declarative configuration. Down the road, this approach also
allows for automation through scripts and tools.
@andymccurdy
Copy link
Contributor

Looks good, thanks!

@andymccurdy andymccurdy merged commit 7fab03a into redis:master Apr 9, 2020
@jdufresne jdufresne deleted the setup-cfg branch April 13, 2020 18:53
@akx akx mentioned this pull request Sep 19, 2022
4 tasks
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 19, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 21, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 21, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 21, 2022
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
akx added a commit to akx/redis-py that referenced this pull request Sep 4, 2023
akx added a commit to akx/redis-py that referenced this pull request Sep 5, 2023
akx added a commit to akx/redis-py that referenced this pull request Feb 15, 2024
akx added a commit to akx/redis-py that referenced this pull request Jun 12, 2024
akx added a commit to akx/redis-py that referenced this pull request Aug 27, 2024
akx added a commit to akx/redis-py that referenced this pull request Aug 27, 2024
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
akx added a commit to akx/redis-py that referenced this pull request Oct 16, 2024
akx added a commit to akx/redis-py that referenced this pull request Feb 20, 2025
akx added a commit to akx/redis-py that referenced this pull request Feb 20, 2025
akx added a commit to akx/redis-py that referenced this pull request Feb 25, 2025
petyaslavova pushed a commit that referenced this pull request Feb 25, 2025
* Switch to PEP 517 packaging using hatchling

Refs #1316
Refs #1649
Remake of #2388

Co-authored-by: Ofek Lev <[email protected]>

* Use a single source of truth for version info

* Uninstall redis wheel installed as redis-entraid dep

* Add build as dev_requirement

* Get rid of requirements.txt

* Get rid of setuptools and wheel deps

* Move pytest configuration to pyproject.toml

* Retain tests and dev_requirements.txt in sdist

---------

Co-authored-by: Ofek Lev <[email protected]>
petyaslavova pushed a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
* Switch to PEP 517 packaging using hatchling

Refs redis#1316
Refs redis#1649
Remake of redis#2388

Co-authored-by: Ofek Lev <[email protected]>

* Use a single source of truth for version info

* Uninstall redis wheel installed as redis-entraid dep

* Add build as dev_requirement

* Get rid of requirements.txt

* Get rid of setuptools and wheel deps

* Move pytest configuration to pyproject.toml

* Retain tests and dev_requirements.txt in sdist

---------

Co-authored-by: Ofek Lev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants