Skip to content

Replacing the redis and redis-stack-server images with redis-libs-tests image in test infrastructure #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2025
Merged

Replacing the redis and redis-stack-server images with redis-libs-tests image in test infrastructure #3505

merged 5 commits into from
Feb 13, 2025

Conversation

petyaslavova
Copy link
Collaborator

@petyaslavova petyaslavova commented Feb 11, 2025 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

  • Replacing the redis and redis-stack-server images with the redis-libs-tests image in test infrastructure - change affects docker containers for redis-stack, replica and sentinel.
  • Updating the version in setup.py to the current stable version (5.2.1)

@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Feb 11, 2025
@petyaslavova petyaslavova force-pushed the ps_replace_redis_image_in_test_infra branch from 4d642b3 to 006583b Compare February 11, 2025 11:45
@petyaslavova petyaslavova marked this pull request as draft February 11, 2025 11:57
@petyaslavova petyaslavova changed the title [Draft] Replacing the redis image with redis-libs-tests image in test infrastructure Replacing the redis image with redis-libs-tests image in test infrastructure Feb 11, 2025
@petyaslavova petyaslavova force-pushed the ps_replace_redis_image_in_test_infra branch from 006583b to f3e5def Compare February 11, 2025 12:35
@petyaslavova petyaslavova marked this pull request as ready for review February 11, 2025 12:43
vladvildanov
vladvildanov reviewed Feb 11, 2025
View reviewed changes
@vladvildanov
Copy link
Collaborator

@petyaslavova Could we also replace current official redis-stack-server image with the one from client-libs-test as a part of this PR?

@petyaslavova
Copy link
Collaborator Author

@petyaslavova Could we also replace current official redis-stack-server image with the one from client-libs-test as a part of this PR?

I will try - I'm not sure what will happen with the older versions that don't have modules, but I will check if/how it can be replaced. ..

@vladvildanov
Copy link
Collaborator

@petyaslavova There's all versions of redis-stack images that includes modules, should be an easy replacement. Here's a stack images:
rs-7.2.0-v14
rs-6.2.6-v18
rs-7.4.0-v2
https://hub.docker.com/r/redislabs/client-libs-test/tags

@petyaslavova petyaslavova force-pushed the ps_replace_redis_image_in_test_infra branch 2 times, most recently from ee3ac53 to 6f42577 Compare February 12, 2025 12:22
@petyaslavova
Copy link
Collaborator Author

@petyaslavova There's all versions of redis-stack images that includes modules, should be an easy replacement. Here's a stack images: rs-7.2.0-v14 rs-6.2.6-v18 rs-7.4.0-v2 https://hub.docker.com/r/redislabs/client-libs-test/tags

Done and added to the review.

@petyaslavova petyaslavova changed the title Replacing the redis image with redis-libs-tests image in test infrastructure Replacing the redis and redis-stack-server images with redis-libs-tests image in test infrastructure Feb 12, 2025
@petyaslavova petyaslavova force-pushed the ps_replace_redis_image_in_test_infra branch from 6f42577 to c755cf9 Compare February 12, 2025 13:03
@petyaslavova petyaslavova merged commit db74c1a into master Feb 13, 2025
37 checks passed
@petyaslavova petyaslavova deleted the ps_replace_redis_image_in_test_infra branch February 13, 2025 12:45
petyaslavova added a commit that referenced this pull request Apr 30, 2025
@petyaslavova
Replacing the redis and redis-stack-server images with redis-libs-tes…
46740c8 
…ts image in test infrastructure (#3505)

* Replacing the redis image with redis-libs-tests image in test infrastructure

* Replacing redis-stack-server image usage with client-libs-test. Fixing lib version in setup.py

* Defining stack tag variable for the build and test github action

* Removing unused env var from build and test github actions
petyaslavova added a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
@petyaslavova
Replacing the redis and redis-stack-server images with redis-libs-tes…
83162c2 
…ts image in test infrastructure (redis#3505)

* Replacing the redis image with redis-libs-tests image in test infrastructure

* Replacing redis-stack-server image usage with client-libs-test. Fixing lib version in setup.py

* Defining stack tag variable for the build and test github action

* Removing unused env var from build and test github actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petyaslavova @vladvildanov