Removing connection_pool field from the CommandProtocol definition #3656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
With this change, the requirement to initialize
connection_pool
in every class that directly or indirectly inherits fromCommandsProtocol
is removed.The protocol should define only the methods and properties necessary for command execution. Consumers of
CommandsProtocol
only rely onexecute_command
, so requiringconnection_pool
introduces an unnecessary leak of internal state.In some cases, it's not even applicable—such as with cluster clients, where
connection_pool
is not a direct property of the client.Fixes #3574