Skip to content

Removing connection_pool field from the CommandProtocol definition #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petyaslavova
Copy link
Collaborator

@petyaslavova petyaslavova commented May 23, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

With this change, the requirement to initialize connection_pool in every class that directly or indirectly inherits from CommandsProtocol is removed.

The protocol should define only the methods and properties necessary for command execution. Consumers of CommandsProtocol only rely on execute_command, so requiring connection_pool introduces an unnecessary leak of internal state.
In some cases, it's not even applicable—such as with cluster clients, where connection_pool is not a direct property of the client.

Fixes #3574

@petyaslavova petyaslavova added the techdebt Things that can be improved or refactored label May 23, 2025
@petyaslavova petyaslavova requested a review from vladvildanov May 23, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
techdebt Things that can be improved or refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to instantiate RedisCluster according to pyright
1 participant