Skip to content

Fix mutable nested record #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Fix mutable nested record #7470

merged 3 commits into from
May 14, 2025

Conversation

shulhi
Copy link
Member

@shulhi shulhi commented May 14, 2025

Fix #7405

@shulhi shulhi requested a review from zth May 14, 2025 06:51
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 14, 2025 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7470

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7470

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7470

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7470

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7470

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7470

commit: d64a396

zth
zth approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you very much!

@shulhi shulhi force-pushed the fix/mutable-nested-record branch from 570493d to d64a396 Compare May 14, 2025 08:52
@zth zth merged commit fd26d3a into rescript-lang:master May 14, 2025
21 checks passed
@shulhi shulhi deleted the fix/mutable-nested-record branch May 14, 2025 12:07
@shulhi shulhi mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support mutable for nested record fields
2 participants
@shulhi @zth