Show variant constructor's inline record types on hover #7519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hovering a variant constructor currently only shows payload type information if it uses arguments, but not if it has an inline record:
rescript/analysis/src/Hover.ml
Lines 275 to 283 in dd1f753
My first commit fixes this by using
CompletionBackEnd.showConstructor
.My second commit moved where we show constructor payload type information from the end of the markdown hover text to instead be right after the name of the variant type. This allows users to see payload type information immediately instead of having to scroll through related types first.
This also matches the behaviour of other LSPs, like rust-analyzer:
