-
Notifications
You must be signed in to change notification settings - Fork 765
feat(preview-server): Proper error handling for prettier's invalid HTML error #2265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabrielmfern
wants to merge
19
commits into
canary
Choose a base branch
from
feat/proper-error-handling-for-invalid-html
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca8032d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
1f9932d
to
ca8032d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a custom JSX runtime that we use for rendering all emails that allow for tying HTML elements back into the React source file and line. It does that so that it can add the line into the start of the stack trace of the React code that actually ends up rendering as invalid HTML pointed out by prettier:
The way we get the attribute from the prettier error, though, can fail because we try to find the closest attribute to the offset given by prettier in the html. So, this means it might actually point to the next node instead of the correct one, but only the next one. Not sure if we can circumvent this without having to actually parse the HTML ourselves through some sort of lenient parser.
The JSX runtime has only the dev variant and is just a very thin wrapper around the one from
react/jsx-dev-runtime
that we bundle in withesbuild
to get the user's version of it and not the preview server's. This change can also benefit other places like the different checkersIt also improves the error overlay's UI quite a lot, along with customizing how the parsing error message gets rendered. So, the end result is