Skip to content

Expose the ability to invoke grpc services from handler services, and viceversa. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

slinkydeveloper
Copy link
Collaborator

Fix #171

@@ -555,4 +565,8 @@ export class RpcContextImpl implements RpcContext {
public sleep(millis: number): Promise<void> {
return this.ctx.sleep(millis);
}

grpcChannel(): RestateGrpcChannel {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need the oneWayCall and delayed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slinkydeveloper slinkydeveloper merged commit 7e505d9 into restatedev:main Nov 1, 2023
@slinkydeveloper slinkydeveloper deleted the issues/171 branch November 1, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't invoke grpc Restate services from handler api
2 participants