Add a .catch() for the dangling promises #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Node, a rejected promises without a .catch() causes the process to exit. We have few places in our API that create promises internally but do not expose them back to the caller. For example: ctx.set(), ctx.reject/resolve awakable, etc'. These promises might get rejected, due to for example non determinism errors. This commit adds a .catch() call, that forwards the failure back to the FSM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node, a rejected promises without a .catch() causes the process to exit. We have few places in our API that create promises internally but do not expose them back to the caller. For example: ctx.set(), ctx.reject/resolve awakable, etc'. These promises might get rejected, due to for example non determinism errors.
This PR adds a .catch() call, that forwards the failure back to the FSM.