Expose the original Request #283
Conversation
| * A request object includes the request headers, and the raw unparsed | ||
| * request body. | ||
| */ | ||
| export interface Request { |
There was a problem hiding this comment.
How about moving the field Context.id and Context.serviceName (which needs to be renamed) here as well?
There was a problem hiding this comment.
do u have it like that in the java sdk?
There was a problem hiding this comment.
i don't have serviceName in java sdk (seems redundant to me 🤷 ), id yes i have it, it's named Request#invocationId(): https://github.com/restatedev/sdk-java/blob/main/sdk-common/src/main/java/dev/restate/sdk/common/Request.java#L27
There was a problem hiding this comment.
the id is used in various places, so I don't want to do this as part of the passing headers PR.
There was a problem hiding this comment.
as discussed offline, moved to the request object, and serviceName removed.
This commit exposes the raw request on the Context. A request represents the raw request as issued for this handler. This includes the request headers, and the raw body.
igalshilman
force-pushed
the
pass_headers
branch
from
8e129dc to
81721a9
Compare
|
Thanks for your fast review @slinkydeveloper, going to merge this once green. |
This PR exposes the raw request on the Context. A request represents the raw request as issued for this handler. This includes the request headers, and the raw body.