Skip to content

Denodeify #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2024
Merged

Denodeify #321

merged 2 commits into from
Apr 18, 2024

Conversation

jackkleeman
Copy link
Contributor

@jackkleeman jackkleeman commented Apr 18, 2024 •
edited
Loading

In conjunction with:

  • module: es6
  • moduleResolution: nodenext
  • deleting the http2 stuff in endpoint.ts and endpoint_impl.ts

this will build a bundle that works in cloudflare workers

@jackkleeman
Partial denodeification
04259c6 
Other than the http2 import, wrangler dev no longer complains with these changes
@jackkleeman
Buffer denodeification
aed527f
@jackkleeman jackkleeman requested a review from igalshilman April 18, 2024 10:49
@github-actions GitHub Actions
Copy link

Test Results

 95 files  ±0   95 suites  ±0   8m 22s ⏱️ +3s
 82 tests ±0   80 ✅ ±0  2 💤 ±0  0 ❌ ±0 
212 runs  ±0  206 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit aed527f. ± Comparison against base commit 146ab62.

igalshilman
igalshilman approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jackkleeman jackkleeman merged commit b4f9f95 into main Apr 18, 2024
@jackkleeman jackkleeman deleted the denodeify branch April 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkleeman @igalshilman