-
Notifications
You must be signed in to change notification settings - Fork 12
Add zod module #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zod module #502
Conversation
bdbddc3
to
2171e2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🤩
"files": [ | ||
"dist" | ||
], | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
"devDependencies": { | |
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind, we are only using the types from @restatedev/restate-sdk-core
"devDependencies": { | ||
"@restatedev/restate-sdk-core": "^1.4.0" | ||
}, | ||
"dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and maybe this should be
"dependencies": { | |
"peerDependencies": { |
I appreciate that this is being made optional and not mandatory. |
@igalshilman - What am I doing wrong? With deps: "@restatedev/restate-sdk": "0.0.0-SNAPSHOT-20241220152906",
"@restatedev/restate-sdk-zod": "0.0.0-SNAPSHOT-20250312193516",
"zod": "3.23.8", |
@mupperton take the latest deps (delete the package-lock) here is a usage example here: https://github.com/restatedev/sdk-typescript/blob/main/packages/restate-sdk-examples/src/zod_greeter.ts |
@igalshilman Found my issue, I had Btw that example doesn't have the zod packages listed in the package dependencies |
@mupperton ok good to hear that is resolved! But also the Also, how would you recommend to specify the dependencies in |
Ah, the For specifying the deps, my only suggestion would be aligning the minimum zod version with that of |
Uh oh!
There was an error while loading. Please reload this page.