Skip to content

Fix this type #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Fix this type #534

merged 3 commits into from
May 7, 2025

Conversation

nikrooz
Copy link
Contributor

@nikrooz nikrooz commented May 1, 2025

Screenshot 2025-05-01 at 12 13 27

@nikrooz
fix this type
dd0db49 
Signed-off-by: Nik Nasr <[email protected]>
@nikrooz nikrooz force-pushed the NN_fix-this-type branch from dea25f0 to dd0db49 Compare May 5, 2025 13:02
@nikrooz
fix formatting
f250881 
Signed-off-by: Nik Nasr <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

Test Results

  7 files  ±0    7 suites  ±0   3m 53s ⏱️ +5s
 54 tests ±0   53 ✅ ±0  1 💤 ±0  0 ❌ ±0 
223 runs  ±0  220 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit f098464. ± Comparison against base commit 1ca10e4.

♻️ This comment has been updated with latest results.

igalshilman
igalshilman approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikrooz nikrooz merged commit 9f844cb into main May 7, 2025
3 checks passed
@nikrooz nikrooz deleted the NN_fix-this-type branch May 7, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikrooz @igalshilman