Add missing exports #542
Merged
Add missing exports #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nik Nasr <[email protected]>
nikrooz
commented
May 16, 2025
| "@restatedev/restate-sdk-core": "^1.5.4", | ||
| "@restatedev/restate-sdk": "^1.5.4", |
There was a problem hiding this comment.
We were missing @restatedev/restate-sdk as a dependency because we use endpoint from this package. Since all the types we needed from @restatedev/restate-sdk-core are available in @restatedev/restate-sdk, I removed the former.
nikrooz
commented
May 16, 2025
Comment on lines
-14
to
+22
| import * as restate from "@restatedev/restate-sdk"; | ||
| import * as core from "@restatedev/restate-sdk-core"; | ||
| import { endpoint, serde } from "@restatedev/restate-sdk"; | ||
| import type { | ||
| TypedState, | ||
| UntypedState, | ||
| Serde, | ||
| RestateEndpoint, | ||
| VirtualObjectDefinition, | ||
| WorkflowDefinition, | ||
| } from "@restatedev/restate-sdk"; |
There was a problem hiding this comment.
Importing with import * as restate from "@restatedev/restate-sdk" is vague because it does not specify which parts of @restatedev/restate-sdk will be used. Therefore, api-extractor requires exporting the entire restate, which is why I used named imports here.
Signed-off-by: Nik Nasr <[email protected]>
Signed-off-by: Nik Nasr <[email protected]>
Signed-off-by: Nik Nasr <[email protected]>
igalshilman
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the missing exports caught by #541