Skip to content

Add unstack op #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

OriolAbril
Copy link

@OriolAbril OriolAbril commented May 22, 2025

Description

First pass at unstack. It is working already, need to sort out tests and double check the order in which unstack happens.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1.org.readthedocs.build/en/1/

@OriolAbril
Copy link
Author

@ricardoV94 let me know if the PR should have been done in a different way and how the code looks. As I commented in the test code itself, tests currently pass but I am only checking matching shapes with xarray, the actual elements are different. I have to figure out if the idea I had of testing the complementary operation to circumvent the fact that xarray's unstack needs coordinates can't actually be used or if I am inverting some stack(new_dim=["a", "b"] while the other has ["b", "a"].

@ricardoV94
Copy link
Owner

Are the unstack dims in the same order as xarray?

@ricardoV94
Copy link
Owner

Closing in favor of pymc-devs#1412

@ricardoV94 ricardoV94 closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants