fix: use document.baseURI for sheetHref when handling inline styles #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 43689b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logic for handling inline stylesheets by using document.baseURI to resolve URLs in inline styles.
- Updated utils.ts to use baseURI over location.href for inline <style> elements.
- Added comprehensive test cases in utils.test.ts to cover scenarios when rules are missing, using cssRules, and verifying URL absolutification with baseURI.
- Included a changeset file detailing the patch update for rrweb-snapshot.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/rrweb-snapshot/test/utils.test.ts | Added test cases for the new stringifyStylesheet behavior |
| packages/rrweb-snapshot/src/utils.ts | Modified inline stylesheet URL resolution to use ownerDocument.baseURI instead of location.href |
| .changeset/twelve-nails-occur.md | Documented the changes and the rationale behind prioritizing the base href resolution |
megboehlert
changed the title
pauldambra
added a commit
to PostHog/posthog-rrweb
that referenced
this pull request
Jun 11, 2025
pauldambra
added a commit
to PostHog/posthog-rrweb
that referenced
this pull request
Jun 11, 2025
packages/rrweb-snapshot/src/utils.ts
Outdated
| @@ -120,7 +120,7 @@ export function stringifyStylesheet(s: CSSStyleSheet): string | null { | |||
| let sheetHref = s.href; | |||
| if (!sheetHref && s.ownerNode && s.ownerNode.ownerDocument) { | |||
| // an inline <style> element | |||
| sheetHref = s.ownerNode.ownerDocument.location.href; | |||
| sheetHref = s.ownerNode.ownerDocument.baseURI; | |||
There was a problem hiding this comment.
Suggested change
| sheetHref = s.ownerNode.ownerDocument.baseURI; | |
| sheetHref = s.ownerNode.baseURI; |
I don't think the ownerDocument bit is necessary anymore!
There was a problem hiding this comment.
Good call out! I opened a new PR with this change.
eoghanmurray
previously approved these changes
Jun 13, 2025
megboehlert
force-pushed
the
mb-fix-stylesheet-href-when-base-tag-present
branch
from
5e2d383 to
43689b7
Compare
|
new PR with requested changes here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize using the href from base tag (if present) when stringifying urls in inline stylesheets. Document.baseURI does just this. If a base tag is not present, it falls back to location.href.