Skip to content

Bump golang.org/x/crypto from 0.31.0 to 0.35.0 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 14, 2025

Bumps golang.org/x/crypto from 0.31.0 to 0.35.0.

Commits
  • 7292932 ssh: limit the size of the internal packet queue while waiting for KEX
  • f66f74b acme/autocert: check host policy before probing the cache
  • b0784b7 x509roots/fallback: drop obsolete build constraint
  • 911360c all: bump golang.org/x/crypto dependencies of asm generators
  • 89ff08d all: upgrade go directive to at least 1.23.0 [generated]
  • e47973b all: update certs for go1.24
  • 9290511 go.mod: update golang.org/x dependencies
  • fa5273e x509roots/fallback: update bundle
  • a8ea4be ssh: add ServerConfig.PreAuthConnCallback, ServerPreAuthConn (banner) interface
  • 71d3a4c acme: support challenges that require the ACME client to send a non-empty JSO...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.31.0 to 0.35.0.
- [Commits](golang/crypto@v0.31.0...v0.35.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.35.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Apr 14, 2025
@rubenv
Copy link
Owner

rubenv commented Apr 15, 2025

@dependabot ignore this minor version

sql-migrate is not affected by this, it doesn't have an SSH server.

@rubenv rubenv closed this Apr 15, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 15, 2025

OK, I won't notify you about version 0.35.x again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/go_modules/golang.org/x/crypto-0.35.0 branch April 15, 2025 08:06
@yevheniipererva
Copy link

yevheniipererva commented Apr 15, 2025

@rubenv While it's true that sql-migrate isn't directly affected by this issue, many security scanners still flag high-severity CVEs regardless of usage context. This can create friction for downstream users, especially in environments with strict compliance requirements. Updating the dependency helps avoid those issues with minimal risk.

@rubenv
Copy link
Owner

rubenv commented Apr 15, 2025 via email

@zyv4yk
Copy link
Contributor

zyv4yk commented Apr 15, 2025

but not if it breaks compatibility with previous versions of Go.

@rubenv, should we care about support go versions that are not maintained anymore?
as said in go docs

Each major Go release is supported until there are two newer major releases. We fix critical problems, including critical security problems, in supported releases as needed by issuing minor revisions

So it looks like we shouldn't care about about versions < 1.23

@rubenv
Copy link
Owner

rubenv commented Apr 15, 2025

@zyv4yk I removed support for older versions, but 1.23 is a requirement.

@zyv4yk
Copy link
Contributor

zyv4yk commented Apr 15, 2025

ok, I'll try to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants