create sockets with SO_REUSEPORT option #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this not merged yet? This fixes a very important bug.. |
|
I am also very interested in having this merged and released. What is blocking it? |
carlobeltrame
added a commit
to carlobeltrame/hitobito-docker
that referenced
this pull request
Dec 3, 2019
As similarly proposed in ruby-debug/ruby-debug-ide#107 This hack is necessary as long as ruby-debug/ruby-debug-ide#164 is not merged and released because: * We cannot easily modify the Gemfile because it is not in the same repository. So we need to use `gem install` in the Dockerfile to do it * The newest RubyMine requires a prerelease version of ruby-debug-ide * The fix with SO_REUSEPORT is only available on a specific branch of a specific fork, which is not up-to-date with the prerelease version * We cannot use the monkey-patch in an initializer as proposed in the issue, because wagon:test doesn't run Rails and thus doesn't consider the initializers The combination of these three aspects renders it impossible to easily install a version that includes the fix. So instead, we simply overwrite the relevant code inside the bundle with something that works for our case for now. As soon as the PR is merged and released, we can revert to installing the official, unaltered version into our docker container.
|
🙏 |
|
@avantjustus @carlobeltrame @vivekcoer Did you tried the version from the branch? Because AFAIR I put it off because it fails pretty often |
carlobeltrame
added a commit
to carlobeltrame/hitobito-docker
that referenced
this pull request
Feb 25, 2020
As similarly proposed in ruby-debug/ruby-debug-ide#107 This hack is necessary as long as ruby-debug/ruby-debug-ide#164 is not merged and released because: * We cannot easily modify the Gemfile because it is not in the same repository. So we need to use `gem install` in the Dockerfile to do it * The newest RubyMine requires a prerelease version of ruby-debug-ide * The fix with SO_REUSEPORT is only available on a specific branch of a specific fork, which is not up-to-date with the prerelease version * We cannot use the monkey-patch in an initializer as proposed in the issue, because wagon:test doesn't run Rails and thus doesn't consider the initializers The combination of these three aspects renders it impossible to easily install a version that includes the fix. So instead, we simply overwrite the relevant code inside the bundle with something that works for our case for now. As soon as the PR is merged and released, we can revert to installing the official, unaltered version into our docker container.
|
Closing this as abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often in the case of a remote connection, there is a problem with the fact that debugger use several ports in case of multi-process applications. It turns out that there is an opportunity to create several sockets on the same port - REUSEPORT(REUSEADDR in case of windows)(https://stackoverflow.com/a/14388707/4863418)
According this answer REUSEPORT will work on linux starting with 3.9 kernel version(which was released back in 2013 so we are OK)
Old workaround: #73