-
-
Notifications
You must be signed in to change notification settings - Fork 316
Support windows-11-arm #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@MSP-Greg @larskanis I can start working on a PR for that, but I'd like to hear your thoughts. |
665568a
to
b3570f7
Compare
Thanks to notify me about the new Windows on ARM64 runners!
This shouldn't be too difficult. Since the same MSYS2 x64 executables are used on arm64 as on x64, the There is no need to select distinct packages regarding |
Not that easy. The way |
This PR is ready for review. The tests are failing because other linked PRs are required. Also there is a chicken-and-egg problem with this PR and ruby/setup-msys2-gcc#21, which has a few ways to get worked around. The ways I get it solved in my own forks is that:
|
And there is no plan to add it by GitHub? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but of course we'll need to wait that the related PRs are ready and approved as well
It's documented here: https://github.com/actions/partner-runner-images/blob/main/images/arm-windows-11-image.md#omitted-software - I think this essentially means they don't plan to add it. |
It seems worth asking (via issue/discussion) or searching issues, that list includes things that probably don't exist on windows-arm64, but MSYS2 does work there so not clear why it's not included to me. |
actions/partner-runner-images#88 Someone already asked, and it looks like they don't like the fact that msys2 for windows arm64 has hybird x64 emulation and arm64 native... |
ed9deb9
to
e265e38
Compare
I added a commit in this PR to address the circular dependency on this PR and ruby/setup-msys2-gcc#21. The plan of action is:
|
db3f7fa
to
655c29d
Compare
Today I added PR's to my forks of setup-ruby and setup-msys2-gcc, and generated the two 7z files needed for arm64. So, they now exist in the ruby/setup-msys2-gcc release. You should be able to remove the 'Temporarily disable installGCCTools' commit and CI should pass, as it did in my fork. After this is accepted, we can switch the 'setup-msys2-gcc' PR back to using Thanks again, Greg |
Thanks, this greatly simplifies the operation here.
That PR is already using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all your work on this!
GitHub Actions recently added new windows-11-arm runner for OSS: https://github.blog/changelog/2025-04-14-windows-arm64-hosted-runners-now-available-in-public-preview/
This PR and the following adds support for windows-11-arm: