Should Peripheral support array?

[kjetilkjeka]

Register can take the variant Single(RegisterInfo) or Array(RegisterInfo, RegisterArrayInfo). The svd dim stuff is also valid for a peripheral, shouldn't that mean Peripheral should do the same?

What I suggest is to:

1. Rename RegisterArrayInfo to DimInfo (or something else that's generic over these types, like ArrayInfo)
2. Rename Peripheral to PeripheralInfo (to make it analog to RegisterInfo)
3. Introduce the new enum Peripheral which is analog to enum Register
4. Add Peripheral::parse analog to how Register::parse works

Breakage

There are 3 crates listed on crates.io as dependent on this crate. Only svd2rust have received updates in 2017.

Right now svd2rust silently generates garbage code when given peripheral arrays. It should be trivial to apply a quick patch which crashes the program when faced peripheral arrays and works as previous when faced single peripherals. This patch is also a prerequisite of supporting peripheral arrays in svd2rust. In other words, the breakage caused by this patch would be trivial to fix and benefit svd2rust greatly both immediately and in the future.

[robamu]

What is the state of this? I am trying to generate a PAC for the VA108xx0 devices and I issues with blocks like this

        <register derivedFrom="INT_RAM_SBE">
          <dim>32</dim>
          <dimIncrement>4</dimIncrement>
          <name>TIM[%s]</name>
          <description>TIM Interrupt Redirect Selection</description>
          <addressOffset>0x100</addressOffset>
        </register>

        <register derivedFrom="NMI">
          <dim>32</dim>
          <dimIncrement>4</dimIncrement>
          <name>IRQS[%s]</name>
          <description>Interrupt Status Register</description>
          <addressOffset>0x800</addressOffset>
        </register>

also crashes with a quite useless error message: [ERROR svd2rust] expected ,``

[Emilgardis]

Is this SVD file public? If not, could you post the entire stdout/stderr?

[robamu]

You can find a repository with my attempts here: https://github.com/robamu/va108xx-rs .
There is a file where svd2rust was working with some warnings, I removed some of these blocks there. However, others don't appear to be problematic.. This is really odd..

[robamu]

Ahh I have another idea. Maybe svd2rust only has issues with these register array blocks if they are derived from another register. There is an open issue about this: rust-embedded/svd2rust#361

[robamu]

I was able to improve the error message with the changes implemented in #157