Parse <register><alternateRegister> elements #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
reviewed
Mar 15, 2018
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| *.rs.bk | |||
| .*sw* | |||
There was a problem hiding this comment.
[._]*.sw[a-p] is a better solution for matching vim swap files.
src/lib.rs
Outdated
| |s| { | ||
| s.to_owned() | ||
| }, | ||
| ), |
There was a problem hiding this comment.
This indentation is uneeded
tree.attributes.get("derivedFrom").map(|s| s.to_owned()),There was a problem hiding this comment.
I copied this from the other instance of derivedFrom. Note that the .rustfmt.toml config wants this to be:
derived_from: tree.attributes
.get("derivedFrom")
.map(|s| s.to_owned()),
There are other portions that are not rustfmt'd. Would you like me to insert a commit that applies rustfmt underneath my changes and then make them match?
|
#51 for rustfmt, I'll amend this one independently from that for now |
|
(force pushed with your suggested changes; you'll probably need to hard refresh the PR page) |
wez
added a commit
to wez/svd2rust
that referenced
this pull request
Mar 15, 2018
This is a very basic first cut at expanding registers with derivedFrom. This commit requires rust-embedded/svd#50
|
Thank you! bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 16, 2018
50: Parse <register><alternateRegister> elements r=Emilgardis a=wez In looking at rust-embedded/svd2rust#191 and rust-embedded/svd2rust#16 I thought that this might help, so here's the trivial patch.
Build succeeded |
wez
added a commit
to wez/svd2rust
that referenced
this pull request
Apr 20, 2018
This is a very basic first cut at expanding registers with derivedFrom. This commit requires rust-embedded/svd#50
wez
added a commit
to wez/svd2rust
that referenced
this pull request
Apr 20, 2018
This is a very basic first cut at expanding registers with derivedFrom. This commit requires rust-embedded/svd#50
wez
added a commit
to wez/svd2rust
that referenced
this pull request
May 8, 2018
This is a very basic first cut at expanding registers with derivedFrom. This commit requires rust-embedded/svd#50
wez
added a commit
to wez/svd2rust
that referenced
this pull request
May 9, 2018
This is a very basic first cut at expanding registers with derivedFrom. This commit requires rust-embedded/svd#50
wez
added a commit
to wez/svd2rust
that referenced
this pull request
Aug 22, 2018
This is a very basic first cut at expanding registers with derivedFrom. This commit requires rust-embedded/svd#50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking at rust-embedded/svd2rust#191 and rust-embedded/svd2rust#16 I thought that this might help, so here's the trivial patch.