Handle missing dimIndex on registers #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the SVD spec, dimIndex is not required: > By default, <dimIndex> is a value starting with 0. > Remark: Do not define <dimIndex> when using the placeholder [%s] in <name> or <displayName>. I interpret this as it being optional whether the name uses "%s" or "[%s]". Atmel SAMD21 SVDs use "%s" with no dimIndex for 0-indexed arrays. This also tests that dimIndex is sequential and numeric in a single pass without allocating temporary vectors, and fixes the typo adresses -> addresses.
|
Not sure how I missed this, but this PR also addresses the issues I had mentioned in #177. 👍 from me! |
|
@therealprof you may want to test your svds with this branch. |
|
@jamesmunns For the ATSAMD the result is pretty much the same (as far as I can tell from memory it's indentical) as with your PR. The result in this particular case is still broken but I blame Atmel here. |
|
@therealprof Yeah, the SAMD SVDs will still need some more features implemented including |
|
@homunkulus r+ |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 24, 2018
168: Handle missing dimIndex on registers r=japaric a=kevinmehall This supersedes @lucasbrendel's similar PR #153 and fixes #150. Per the [SVD spec](http://arm-software.github.io/CMSIS_5/SVD/html/elem_special.html#dimElementGroup_gr), dimIndex is not required: > By default, \<dimIndex\> is a value starting with 0. > Remark: Do not define \<dimIndex\> when using the placeholder [%s] in \<name\> or \<displayName\>. I interpret this as the element being optional with "%s" and not allowed with "[%s]" (this change does not reject the latter). Atmel SAMD21 SVDs use "%s" with no dimIndex for 0-indexed arrays. This also tests that dimIndex is sequential and numeric in a single pass without allocating temporary vectors, and fixes the typo adresses -> addresses.
Build failed |
|
bors retry |
|
bors-ng doesn't seem to have a retry command implemented, then ... bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 24, 2018
168: Handle missing dimIndex on registers r=japaric a=kevinmehall This supersedes @lucasbrendel's similar PR #153 and fixes #150. Per the [SVD spec](http://arm-software.github.io/CMSIS_5/SVD/html/elem_special.html#dimElementGroup_gr), dimIndex is not required: > By default, \<dimIndex\> is a value starting with 0. > Remark: Do not define \<dimIndex\> when using the placeholder [%s] in \<name\> or \<displayName\>. I interpret this as the element being optional with "%s" and not allowed with "[%s]" (this change does not reject the latter). Atmel SAMD21 SVDs use "%s" with no dimIndex for 0-indexed arrays. This also tests that dimIndex is sequential and numeric in a single pass without allocating temporary vectors, and fixes the typo adresses -> addresses.
Timed out |
|
All tests passed. Merging manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes @lucasbrendel's similar PR #153 and fixes #150.
Per the SVD spec, dimIndex is not required:
I interpret this as the element being optional with "%s" and not allowed with "[%s]" (this change does not reject the latter). Atmel SAMD21 SVDs use "%s" with no dimIndex for 0-indexed arrays.
This also tests that dimIndex is sequential and numeric in a single pass without allocating temporary vectors, and fixes the typo adresses -> addresses.