Skip to content

fix regress ci problems #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix regress ci problems #783

merged 2 commits into from
Dec 7, 2023

Conversation

Emilgardis
Copy link
Member

follow up to #728

@Emilgardis Emilgardis requested a review from a team as a code owner December 6, 2023 20:35
@Emilgardis Emilgardis added the no changelog no-changelog label Dec 6, 2023
@burrbull burrbull added this pull request to the merge queue Dec 7, 2023
Merged via the queue into master with commit 76cd523 Dec 7, 2023
@burrbull burrbull deleted the improve-regress branch December 7, 2023 04:10
@Emilgardis
Copy link
Member Author

/ci diff pr

Copy link

github-actions bot commented Dec 7, 2023

Diff for comment

@burrbull
Copy link
Member

burrbull commented Dec 7, 2023

Looks like diff downloads SVD twice for baseline and current. Does it?

@Emilgardis
Copy link
Member Author

Yes it does, theres a fixme to fix that

tracing::info!("Downloading SVD");
// FIXME: Avoid downloading multiple times, especially if we're using the diff command
let svd_url = &self.svd_url();
let svd = reqwest::blocking::get(svd_url)
.with_context(|| format!("Failed to get svd URL: {svd_url}"))?
.error_for_status()
.with_context(|| anyhow!("Response is not ok for svd url"))?
.text()
.with_context(|| "SVD is bad text")?;

The fix would probably be to download once and copy/link to respective output folder, then inside setup_case check if the svd already exists and is "new"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants