This repository was archived by the owner on Jun 1, 2019. It is now read-only.
Support multiple projects #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support_multiple_projects
steveklabnik
suggested changes
Jan 28, 2017
| CREATE TABLE contributors ( | ||
| id SERIAL NOT NULL, | ||
| name VARCHAR, | ||
| email VARCHAR |
There was a problem hiding this comment.
should these two also be NOT NULL?
| pub fn assign_commits(log: &slog::Logger, release_name: &str, previous_release: &str, path: &str) { | ||
| pub fn assign_commits(log: &slog::Logger, release_name: &str, previous_release: &str, release_project_id: i32, path: &str) { | ||
| // Could take the connection as a parameter, as problably | ||
| // it's already established somewhere... |
There was a problem hiding this comment.
yeah; i'm totally okay with doing this this way for now; i want to clean up all the connection stuff. we'll get there.
|
@steveklabnik Changed the migration & merged current master, so it does not have merge conflicts. |
steveklabnik
approved these changes
Jan 28, 2017
|
Thanks a ton! Not going to merge just yet as I'd like to test locally first; but this looks awesome ❤️ |
|
I am in the process of deploying this right now, thanks so much @jmatraszek ! |
This was referenced Jan 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the-big-red-buttonwill not work at that time (as it expects different db structure) so either use the previously compiled version or drop directly frompsqlbyTRUNCATE commits; TRUNCATE releases;).contributorstable, which is still not used (to decide if we want to use it in the future, but probably yes). But since the project was renamed maybe we should stick withauthors, which sound more git-ish.