Workspace path is not fully resolved

[jfrimmel]

Setup

I have the following (potentially strange) setup:

$project
├── a
│  ├── Cargo.toml
│  └── src
│     └── main.rs
├── b
│  ├── Cargo.toml
│  └── src
│     └── main.rs
├── c
│  ├── Cargo.toml
│  └── src
│     └── main.rs
└── Cargo.toml # containing `workspace.members = ["a", "b", "c"]`

Problem

If I'm executing cargo install --path ../c in directory b the following error occurs:

error: package `/home/jfrimmel/git/$project/a/Cargo.toml` is a member of the wrong workspace
expected: /home/jfrimmel/git/$project/b/../Cargo.toml
actual:   /home/jfrimmel/git/$project/Cargo.toml

It seems like the paths are not canonicalized before comparison.

Reproducation

~ $ mkdir mwe
~ $ cd mwe/
~/mwe $ cargo new a
     Created binary (application) `a` package
~/mwe $ cargo new b
     Created binary (application) `b` package
~/mwe $ cargo new c
     Created binary (application) `c` package
~/mwe $ cat <<EOF > Cargo.toml
[workspace]
members = ["a", "b", "c"]
EOF
~/mwe $ cd b
~/mwe/b $ cargo install --path ../c --force
error: package `/home/jfrimmel/mwe/a/Cargo.toml` is a member of the wrong workspace
expected: /home/jfrimmel/mwe/b/../Cargo.toml
actual:   /home/jfrimmel/mwe/Cargo.toml
~/mwe/b $ 

Metadata

$ cargo --version
cargo 1.41.0-nightly (8280633db 2019-11-11)

[jfrimmel]

The relevant code part:

cargo/src/cargo/core/workspace.rs

Lines 629 to 645 in df80f80

	for member in self.members.clone() {
	let root = self.find_root(&member)?;
	if root == self.root_manifest {
	continue;
	}
	match root {
	Some(root) => {
	failure::bail!(
	"package `{}` is a member of the wrong workspace\n\
	expected: {}\n\
	actual: {}",
	member.display(),
	self.root_manifest.as_ref().unwrap().display(),
	root.display()
	);
	}

Maybe just some calls to fs::canonicalize() have to be added.

[epage]

In cargo, we don't use std::fs::canonicalize but some path helpers from cargo utils.

[weihanglo]

This should be resolved by #10335 in Rust 1.60.0. Closing.