-
Notifications
You must be signed in to change notification settings - Fork 239
Eliminate build.rs
-generated Aarch64 atomic macros
#951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Regarding #947 (comment): we should make use of the unstable
|
@tgross35 Is it like this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Just two small nits
build.rs
-generated Aarch64 atomic macros
Co-authored-by: Trevor Gross <[email protected]>
Thanks for the changes, I'll double check this tomorrow and merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Replace
build.rs
Rust generation with macros, using the unstable${concat(...)}
.Fixes: #947