Stop returning deprecated badges from API #5071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
jtgeibel
approved these changes
Aug 12, 2022
This was referenced Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Badges were removed from the crates.io UI almost two years ago (see #2436), and they have also been removed from the cargo documentation (see rust-lang/cargo#8727).
This PR adjusts our API to no longer return the list of badges specified in the
Cargo.tomlfile. Instead, we return an empty array (badges: []) to not break any users that expect us to return an array under that key.Note that this change is just the absolute minimum to no longer return the badges, and some more cleanup work can be done afterwards. Ultimately, the goal is to completely drop the badges from the database (needs to be announced in #3617).