Skip to content

fix: Allow flyimport to import primitive shadowing modules #17656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2024
Merged

fix: Allow flyimport to import primitive shadowing modules #17656

merged 1 commit into from
Jul 21, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jul 21, 2024

Fixes #16371

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2024
@Veykril
Copy link
Member Author

Veykril commented Jul 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2024

📌 Commit 0851d21 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 21, 2024

⌛ Testing commit 0851d21 with merge db1343e...

@bors
Copy link
Contributor

bors commented Jul 21, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing db1343e to master...

@bors bors merged commit db1343e into rust-lang:master Jul 21, 2024
11 checks passed
@Veykril Veykril deleted the flyimport-builtin-mod branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

str::from$0 should give importing completions for the module
3 participants
@Veykril @bors @rustbot