Add Applicability to suggestion lints: Take 2 #3459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bugs and some documentation is unrelated to the Applicability change, but these bugs were serious and the documentation was kind of required to understand what's going on.
phansch
added
the
S-waiting-on-review
oli-obk
suggested changes
Nov 27, 2018
| @@ -300,6 +301,7 @@ impl WarningType { | |||
| "mistyped literal suffix", | |||
| "did you mean to write", | |||
| grouping_hint.to_string(), | |||
| Applicability::MachineApplicable, | |||
There was a problem hiding this comment.
I don't think this should be machine applicable. It's just a "looks wrong, needs user attention, probably should be X"
oli-obk
approved these changes
Nov 27, 2018
llogiq
reviewed
Nov 27, 2018
clippy_lints/src/bytecount.rs
Outdated
| format!("bytecount::count({}, {})", | ||
| snippet_with_applicability(cx, haystack.span, "..", &mut applicability), | ||
| snippet_with_applicability(cx, needle.span, "..", &mut applicability)), | ||
| Applicability::Unspecified, |
There was a problem hiding this comment.
Shouldn't that read applicability here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2943 completely redone, so that we finally have applicability levels for our suggestion lints and #2943 can finally be closed.
Resolves #2930
Implements #2943 (comment)
Still open:
multispan_sugg(Should this also be done in this PR?)PS: Sorry for some unrelated formatting changes, those just slipped in ¯\_(ツ)_/¯