Skip to content

Add a note for pre-expansion passes #7090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: none

Just had to turn away a PR for using pre-expansion. I don't think that was the first time. So hopefully this will inform people sooner.

r? flip1995

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2021
@camsteffen
Copy link
Contributor Author

I don't know how to pick a reviewer. Watevs.

@Manishearth
Copy link
Member

@bors r+

you need the @ in the r?

@bors
Copy link
Contributor

bors commented Apr 15, 2021

📌 Commit 014bf43 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 15, 2021

⌛ Testing commit 014bf43 with merge 52c8c9c...

@bors
Copy link
Contributor

bors commented Apr 15, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 52c8c9c to master...

@bors bors merged commit 52c8c9c into rust-lang:master Apr 15, 2021
@camsteffen camsteffen deleted the pre-expansion-note branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants