{} highlighting in debug!

[vors]

Sublime Text Version

Sublime Text 3 (Build 3176)

Rust Enhanced Version

v2.11.0

Operating system

macos 10.13.4

Expected behavior

{} should be highlighted the same way in debug!{"..."} as in println!("...")

Actual behavior

Steps to reproduce

debug!("{}", 1)

[TheIronBorn]

Is the debug macro from another crate or from the Rust library? I can't find a debug macro anywhere in the API reference: https://doc.rust-lang.org/std/index.html.

We can't tell dynamically which macro argument strings are Formatters, so we have to add each formatting macro to a list. The alternative is to highlight all other macro string literals as formatters.

Regular string literals can take {} and such like any other character: https://play.rust-lang.org/?gist=77b40b092a38139f9296e3428089caca&version=stable&mode=debug

[vors]

Yes, debug! is from log crate.

Would it be reasonable to assume that any pattern like that

xxxxxx("string {} with {} few {} placeholders", arg1, arg2, arg3)

where number of placeholders is the same as number of arguments before the closing ), would be Formatter?

[TheIronBorn]

That’s worth consideration at least.

[dten]

It's easy to say that, but to express that in the syntax definition is much harder (unless you know the secret?)

[vors]

It's hard indeed. I even struggle to implement a simpler heuristic: assume that macro takes an fmt-string, if it has at least one parameter after the string parameter.

[sampersand]

i don't see a reason not to just have all strings highlight {} (and its cousins {:?}/{:x}/...); more often than not, if you're going to have any of those in a string, it's going to be for formatting reasons.

[jasonwilliams]

I think until we can come up with a better heuristic, it might be easier to just add debug to https://github.com/rust-lang/rust-enhanced/blob/master/RustEnhanced.sublime-syntax#L178

Im not a big fan of having {} highlighted everywhere, i think we can do better than that

[sampersand]

Maybe add it in just to macro definitions? I find myself making macros often that require fmt semantics (such as log!(Debug, "Message Parser", "Couldn't parse message: {}", msg) or log_err!(Debug, "Message Parser", err, "Couldn't parse message due to error: {}", msg)).

[jasonwilliams]

where number of placeholders is the same as number of arguments before the closing ), would be Formatter?

@vors i think there are too many edge cases for that to be a viable solution
https://doc.rust-lang.org/std/fmt/