Skip to content

Triagebot doesn't autolabel things that change LLVM's submodule #141601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apiraino opened this issue May 26, 2025 · 4 comments · Fixed by #141602
Closed

Triagebot doesn't autolabel things that change LLVM's submodule #141601

apiraino opened this issue May 26, 2025 · 4 comments · Fixed by #141602
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself

Comments

@apiraino
Copy link
Contributor

From Zulip#general > Feedback on github PR UI/UX changes @ 💬.

triagebot doesn't autolabel things that change LLVM's submodule

We should probably fix (or investigate) that
@jieyouxu
Copy link
Member

jieyouxu commented May 26, 2025 •
edited
Loading

Auto-label for src/llvm-project submodule changes might be sufficient? AFAICT there's simply no rule corresponding to that on r-l/r ATM.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 26, 2025
@Urgau Urgau transferred this issue from rust-lang/triagebot May 26, 2025
@Urgau
Copy link
Member

Urgau commented May 26, 2025

Transferred the issue to rust-lang/rust.

@jieyouxu jieyouxu mentioned this issue May 26, 2025
Merged
@jieyouxu
Copy link
Member

#141602

@jieyouxu jieyouxu added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 26, 2025
@apiraino
Copy link
Contributor Author

wow

@apiraino apiraino closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 27, 2025
@matthiaskrgr
Rollup merge of rust-lang#141602 - jieyouxu:llvm-submodule, r=apiraino
732f671 
triagebot: label LLVM submodule changes with `A-LLVM`

Fixes rust-lang#141601.

r? `@apiraino`
rust-timer added a commit that referenced this issue May 27, 2025
@rust-timer
Unrolled build for #141602
4aa1ebb 
Rollup merge of #141602 - jieyouxu:llvm-submodule, r=apiraino

triagebot: label LLVM submodule changes with `A-LLVM`

Fixes #141601.

r? `@apiraino`
github-actions bot pushed a commit to rust-lang/miri that referenced this issue May 28, 2025
@matthiaskrgr
Rollup merge of #141602 - jieyouxu:llvm-submodule, r=apiraino
314b158 
triagebot: label LLVM submodule changes with `A-LLVM`

Fixes rust-lang/rust#141601.

r? `@apiraino`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

triagebot: label LLVM submodule changes with A-LLVM jieyouxu/rust
4 participants
@Urgau @apiraino @jieyouxu @rustbot