core::str::Str.as_slice() should be renamed as_str()

[lilyball]

The method as_slice() in the core::str::Str trait should be renamed to as_str(). This avoids the name collision with core::slice::Vector.as_slice() for types that need to implement both Vector and Str (as I believe Vec<Ascii> should).

I'm filing this issue now to give a chance for anyone to suggest any reasons why this is a bad idea. Otherwise I will go ahead and make the change myself.

[richo]

I'm working in this general direction with my string refactoring
On 25/05/2014 7:13 pm, "Kevin Ballard" notifications@github.com wrote:

The method as_slice() in the core::str::Str trait should be renamed to
as_str(). This avoids the name collision with
core::slice::Vector.as_slice() for types that need to implement both
Vector and Str (as I believe Vec should).

I'm filing this issue now to give a chance for anyone to suggest any
reasons why this is a bad idea. Otherwise I will go ahead and make the
change myself.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/14433
.

[AdamCanady]

I can make this change since it looks like it still needs to be complete?

[huonw]

cc @aturon

[Manishearth]

I don't mind working on this if it needs to be done.

[aturon]

@Manishearth this will likely be done as part of the API stabilization for strings, which should be wrapping up this week.

[richo]

I started on this but it's more work than I expected. I'll do something automated if noone beats me to it.

[japaric]

@aturon Should this still be done for consistency?

There are still a bunch of as_slice (a lot of them in assert_eq!s) in the rust repo, but those are likely to disappear now that we can use &*string/string[], and in the future string == "foo". So, if we want to do this, I think it makes sense to do it after we remove all those as_slices, to reduce the amount of work.

[aturon]

@japaric Yes and yes. This has been waiting a bit while the ergonomics for as_slice were improved.

(Also, in general we haven't done API stabilization for str yet.)

[richo]

I still have the machinery to do this kicking around somewhere from last time.

iirc, my last PR got closed with something like "not yet", say the word and I'll reopen.

[aturon]

@richo Awesome, and thanks for your patience!

[richo]

No stress. (Thanks for dealing with my often stream of consciousness issues and PRs!).

Should I take it that this is worth doing now or wait for the next meeting?

[aturon]

@richo Let me discuss the staging with the team and get back to you.