Skip to content

Explain how the front page evaluation works #14652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jun 4, 2014 · 4 comments
Closed

Explain how the front page evaluation works #14652

brson opened this issue Jun 4, 2014 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 4, 2014

Folks might be confused that it's running on the web.

Either put a link to an explanation under the editor or perhaps link to play.rust-lang.org and explain there.
@thestinger
Copy link
Contributor

I think it would make sense to link from the front page to http://play.rust-lang.org/, and then http://play.rust-lang.org/ can have a link to the source code repository.

@jasonkliu jasonkliu mentioned this issue Jun 6, 2014
Merged
@SergioBenitez
Copy link
Contributor

Would adding a small "open external" icon next to the result that, when clicked, opens up the playpen with the code already in place suffice?

screen shot 2014-06-06 at 7 14 51 am

@steveklabnik
Copy link
Member

@SergioBenitez I like that.

@fhahn
Copy link
Contributor

fhahn commented Sep 11, 2014

It seems like this issue was fixed with rust-lang/prev.rust-lang.org#35 which adds a button to playpen as described by @SergioBenitez above. Can this issue can be closed?

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14652 - Veykril:pat2021, r=Veykril
707382c 
fix: Fix pat fragment handling in 2021 edition

Fixes rust-lang/rust-analyzer#9055

The fix isn't that great, but we are kind of forced to do it the quick and hacky way right now since std has changed the `matches` macro to make use of this now. And for a proper fix we need to track hygiene for identifiers which is a long way off anyways
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @brson @fhahn @SergioBenitez @thestinger