Skip to content

Fix display of warning block if it is first element of the top doc block #119283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

GuillaumeGomez
Copy link
Member

It fixes the display of the warning block "i" element in case it is the first element:

Screenshot from 2023-12-23 11-15-48

It now looks like this:

image

The update for the browser-ui-test framework is because it didn't detect correctly pseudo elements if they ended with a digit or a dash.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 24, 2023

📌 Commit 98b71bf has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2023
@bors
Copy link
Collaborator

bors commented Dec 25, 2023

⌛ Testing commit 98b71bf with merge b87f649...

@bors
Copy link
Collaborator

bors commented Dec 25, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing b87f649 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2023
@bors bors merged commit b87f649 into rust-lang:master Dec 25, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b87f649): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-0.7%, -0.7%] 2
Improvements ✅
(secondary)
-0.4% [-0.6%, -0.3%] 5
All ❌✅ (primary) -0.7% [-0.7%, -0.7%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.686s -> 672.006s (0.20%)
Artifact size: 312.64 MiB -> 312.63 MiB (-0.00%)

@GuillaumeGomez GuillaumeGomez deleted the warning-block-pos branch December 25, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants