Skip to content

Miri CI: test aarch64-apple-darwin in PRs instead of the x86_64 target #141277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

RalfJung
Copy link
Member

The aarch64 target is more important, and also this ensures we cover all main architectures (x86_64, i686, aarch64) in PR CI.

@rustbot
Copy link
Collaborator

rustbot commented May 20, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 20, 2025
@RalfJung
Copy link
Member Author

@rust-lang/miri I feel like changing this is in our purview, so maybe one of you could approve this? :)

@oli-obk
Copy link
Contributor

oli-obk commented May 30, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented May 30, 2025

📌 Commit cb07fd8 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request May 31, 2025
Miri CI: test aarch64-apple-darwin in PRs instead of the x86_64 target

The aarch64 target is more important, and also this ensures we cover all main architectures (x86_64, i686, aarch64) in PR CI.
bors added a commit that referenced this pull request Jun 1, 2025
Rollup of 6 pull requests

Successful merges:

 - #141072 (Stabilize feature `result_flattening`)
 - #141215 (std: clarify Clone trait documentation about duplication semantics)
 - #141277 (Miri CI: test aarch64-apple-darwin in PRs instead of the x86_64 target)
 - #141521 (Add `const` support for float rounding methods)
 - #141812 (Fix "consider borrowing" for else-if)
 - #141832 (library: explain TOCTOU races in `fs::remove_dir_all`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c4ba6b0 into rust-lang:master Jun 1, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 1, 2025
rust-timer added a commit that referenced this pull request Jun 1, 2025
Rollup merge of #141277 - RalfJung:miri-ci, r=oli-obk

Miri CI: test aarch64-apple-darwin in PRs instead of the x86_64 target

The aarch64 target is more important, and also this ensures we cover all main architectures (x86_64, i686, aarch64) in PR CI.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 1, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#141072 (Stabilize feature `result_flattening`)
 - rust-lang/rust#141215 (std: clarify Clone trait documentation about duplication semantics)
 - rust-lang/rust#141277 (Miri CI: test aarch64-apple-darwin in PRs instead of the x86_64 target)
 - rust-lang/rust#141521 (Add `const` support for float rounding methods)
 - rust-lang/rust#141812 (Fix "consider borrowing" for else-if)
 - rust-lang/rust#141832 (library: explain TOCTOU races in `fs::remove_dir_all`)

r? `@ghost`
`@rustbot` modify labels: rollup
@RalfJung RalfJung deleted the miri-ci branch June 1, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants