x86 (32/64): go back to passing SIMD vectors by-ptr #141309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2025
x86 (32/64): go back to passing SIMD vectors by-ptr Fixes rust-lang#139029 by partially reverting rust-lang#135408 and going back to passing SIMD vectors by-ptr on x86. Sadly, by-val confuses the LLVM inliner so much that it's not worth it... r? `@tgross35` Cc `@nikic` try-job: `test-various*` try-job: x86_64-gnu-nopt try-job: dist-i586-gnu-i586-i686-musl try-job: x86_64-msvc-1
tgross35
approved these changes
May 20, 2025
|
☀️ Try build successful - checks-actions |
nikic
approved these changes
May 21, 2025
|
Is there an LLVM issue we can reference? |
We got @nikic's +1. Anyone else we should ask? FWIW this will also help with #141848: for people that disable SSE on an i686 target, the lint at #116558 (hard error on nightly and beta) can actually trigger for "Rust" ABI functions. We don't actually support such configurations, but we did not intent for them to become a hard error so quickly either. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
(That's rust-lang/miri#4367) |
|
We may even consider backporting this, to avoid Rust 1.88 being the only release where a "Rust" ABI function with a by-value SIMD vector on an i686 target modified to disable SSE causes a hard error. (That's not a configuration we intend to support, but it wasn't really meant to hard-error quite so quickly.) See #141848 for context. |
RalfJung
added
the
beta-nominated
I think it's fine to merge with the CI fix 👍 a few other people have looked at this and upvoted the backport, so seems like there's more consensus there anyway. |
|
Which CI fix? This should be good to go as-is.
|
|
Oops I missed that the linked Miri issue has since been fixed. |
|
(mistyped the bors command) @bors r=tgross35,nikic |
bors
added
S-waiting-on-bors
|
lgtm |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 2, 2025
…nikic x86 (32/64): go back to passing SIMD vectors by-ptr Fixes rust-lang#139029 by partially reverting rust-lang#135408 and going back to passing SIMD vectors by-ptr on x86. Sadly, by-val confuses the LLVM inliner so much that it's not worth it... Also fixes rust-lang#141848 by no longer actually using vector registers with the "Rust" ABI. r? `@tgross35` Cc `@nikic` try-job: `test-various*` try-job: x86_64-gnu-nopt try-job: dist-i586-gnu-i586-i686-musl try-job: x86_64-msvc-1
bors
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup of 6 pull requests Successful merges: - #140715 (Clarify &mut-methods' docs on sync::OnceLock) - #141309 (x86 (32/64): go back to passing SIMD vectors by-ptr) - #141677 (Async drop - type instead of async drop fn, fixes #140484) - #141733 (C-variadic functions must be unsafe) - #141858 (Fix typo in `StructuralPartialEq` docs) - #141874 (add f16_epsilon and f128_epsilon diagnostic items) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
|
@bors rollup=iffy
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139029 by partially reverting #135408 and going back to passing SIMD vectors by-ptr on x86. Sadly, by-val confuses the LLVM inliner so much that it's not worth it...
Also fixes #141848 by no longer actually using vector registers with the "Rust" ABI.
r? @tgross35
Cc @nikic
try-job:
test-various*try-job: x86_64-gnu-nopt
try-job: dist-i586-gnu-i586-i686-musl
try-job: x86_64-msvc-1