Optionally don't steal the THIR #141865
Merged
Optionally don't steal the THIR #141865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
The thir is stolen at 2 different places, I think you're only handling 1 now. |
This comment has been minimized.
This comment has been minimized.
Nadrieril
force-pushed
the
dont-steal-thir
branch
2 times, most recently
from
4d54933 to
529b0b4
Compare
This comment has been minimized.
This comment has been minimized.
Nadrieril
force-pushed
the
dont-steal-thir
branch
from
529b0b4 to
1e169d8
Compare
JonathanBrouwer
approved these changes
Jun 1, 2025
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 2, 2025
Optionally don't steal the THIR The THIR being stolen is a recurrent pain for authors of rustc drivers. This makes it optional, so that the `thir_body` query can still be used after analysis of the crate has completed.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 2, 2025
Optionally don't steal the THIR The THIR being stolen is a recurrent pain for authors of rustc drivers. This makes it optional, so that the `thir_body` query can still be used after analysis of the crate has completed.
bors
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup of 5 pull requests Successful merges: - #141767 (ci: use free runner for aarch64-gnu-llvm-19-1 PR job) - #141858 (Fix typo in `StructuralPartialEq` docs) - #141865 (Optionally don't steal the THIR) - #141874 (add f16_epsilon and f128_epsilon diagnostic items) - #141904 (test-float-parse: apply `cfg(not(bootstrap))`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 2, 2025
Rollup merge of #141865 - Nadrieril:dont-steal-thir, r=oli-obk Optionally don't steal the THIR The THIR being stolen is a recurrent pain for authors of rustc drivers. This makes it optional, so that the `thir_body` query can still be used after analysis of the crate has completed.
jieyouxu
pushed a commit
to jieyouxu/rustc-dev-guide
that referenced
this pull request
Jun 3, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#141767 (ci: use free runner for aarch64-gnu-llvm-19-1 PR job) - rust-lang/rust#141858 (Fix typo in `StructuralPartialEq` docs) - rust-lang/rust#141865 (Optionally don't steal the THIR) - rust-lang/rust#141874 (add f16_epsilon and f128_epsilon diagnostic items) - rust-lang/rust#141904 (test-float-parse: apply `cfg(not(bootstrap))`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The THIR being stolen is a recurrent pain for authors of rustc drivers. This makes it optional, so that the
thir_bodyquery can still be used after analysis of the crate has completed.