-
Notifications
You must be signed in to change notification settings - Fork 13.4k
add Cargo.lock
to CI-rustc allowed list for non-CI env
#142232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR modifies If appropriate, please update |
Signed-off-by: onur-ozkan <[email protected]>
Thanks! @bors r+ rollup |
Rollup of 7 pull requests Successful merges: - #129121 (Stabilize `tcp_quickack`) - #142192 (De-duplicate f16 & f128 doctest attributes) - #142193 (add tests for pattern binding drop order edge cases) - #142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - #142228 (rustc-dev-guide subtree update) - #142231 (Run `calculate_matrix` job on `master` to cache citool builds) - #142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #142232 - onur-ozkan:141986, r=Kobzol add `Cargo.lock` to CI-rustc allowed list for non-CI env Changes to dependencies usually require modifying `Cargo.toml`, which would already invalidate the CI-rustc cache if done in non-allowed paths. On non-CI environment, it should be safe to add `Cargo.lock` to the list of allowed paths as there is no real risk aside from a very rare false positive in cases like minor bumps to non-allowed path dependencies without modifying the `Cargo.toml` files. Fixes #141986
Just for awareness of anyone reading along here, it took not even 3 days for someone to hit this "very rare false positive" (#142338). I thought we had discussed this before in #131658? It is not acceptable to have any false positives in this logic. We don't accept very rare false answers by the borrow checker, and we need to apply the same standard here. |
Rollup of 7 pull requests Successful merges: - rust-lang/rust#129121 (Stabilize `tcp_quickack`) - rust-lang/rust#142192 (De-duplicate f16 & f128 doctest attributes) - rust-lang/rust#142193 (add tests for pattern binding drop order edge cases) - rust-lang/rust#142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - rust-lang/rust#142228 (rustc-dev-guide subtree update) - rust-lang/rust#142231 (Run `calculate_matrix` job on `master` to cache citool builds) - rust-lang/rust#142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
Changes to dependencies usually require modifying
Cargo.toml
, which would already invalidate the CI-rustc cache if done in non-allowed paths. On non-CI environment, it should be safe to addCargo.lock
to the list of allowed paths as there is no real risk aside from a very rare false positive in cases like minor bumps to non-allowed path dependencies without modifying theCargo.toml
files.Fixes #141986