Skip to content

Remove invalid assertion back::link::from add_upstream_rust_crates(). #59696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2019
Merged

Remove invalid assertion back::link::from add_upstream_rust_crates(). #59696

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef648f4
Remove invalid assertion back::link::from add_upstream_rust_crates().
michaelwoerister Apr 4, 2019
a6e802a
Add regression test for #59137.
michaelwoerister Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove invalid assertion back::link::from add_upstream_rust_crates().
  • Loading branch information
@michaelwoerister
michaelwoerister committed Apr 4, 2019
commit ef648f4a4936700c7ebf85f82cbcba29a6187bcc
4 changes: 0 additions & 4 deletions src/librustc_codegen_llvm/back/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,10 +1396,6 @@ fn add_upstream_rust_crates(cmd: &mut dyn Linker,

// Same thing as above, but for dynamic crates instead of static crates.
fn add_dynamic_crate(cmd: &mut dyn Linker, sess: &Session, cratepath: &Path) {
// If we're performing LTO, then it should have been previously required
// that all upstream rust dependencies were available in an rlib format.
assert!(!are_upstream_rust_objects_already_included(sess));

// Just need to tell the linker about where the library lives and
// what its name is
let parent = cratepath.parent();
Expand Down