-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[perf only] Drop incremental compilation support #94268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue This'll take forever since there's a bunch of incremental tests it'll basically be doing from scratch, but I think we can wait more easily than try to land support for special handling. |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit d43a71721abab1706e0647706d460e129ab6a381 with merge 1b51d9cec34ac77893b44f41de1a089a44c5b01d... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
d43a717
to
3f473ee
Compare
@bors try |
⌛ Trying commit 3f473eef05efe8af3b5b47e68128e43b84f87b00 with merge 928c2d96572e23c187b113bf6075cdbc2e59c551... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
This removes the majority (all that I could easily find) of incremental support from the compiler. This is not intended to land on master - but is rather used for perf to evaluate the impact incremental has on non-incremental builds, which may provide useful insight into where we can better optimize the conditionals and such that gate incremental today.
3f473ee
to
106f827
Compare
@bors try |
⌛ Trying commit 106f827 with merge 08f996275290797d9c0192603890eb7ae11d7ebd... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
Queued 08f996275290797d9c0192603890eb7ae11d7ebd with parent c651ba8, future comparison URL. |
Finished benchmarking commit (08f996275290797d9c0192603890eb7ae11d7ebd): comparison url. Summary: This benchmark run shows 261 relevant improvements 🎉 but 221 relevant regressions 😿 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
This removes the majority (all that I could easily find) of incremental support
from the compiler. This is not intended to land on master - but is rather used
for perf to evaluate the impact incremental has on non-incremental builds, which
may provide useful insight into where we can better optimize the conditionals
and such that gate incremental today.
Local results estimate near-zero impact -- around 0.5% -- on non-incremental
builds, obviously making incremental builds slower by a good bit. It'll be interesting
to see the bootstrap time impact, too; I have not measured that locally.
This probably misses anything that's not completely trivially dead code, but from at least the hot path of query code there's definitely nothing incremental-related left.
r? @ghost