Skip to content

Fix misguided suggestions in config.toml #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix misguided suggestions in config.toml
- `verbose-tests` is for debugging the test harness, not the tests
themselves. See also rust-lang/rust#76141
- `codegen-units` defaults to `256` whenever `incremental = true`. So
there's no need to explicitly set it to `0` if we already recommend
incremental. See also #795 (comment).
  • Loading branch information
jyn514 committed Aug 31, 2020
commit f07f8fb678f9b1afc38978b1c2ec16b06b48a865
8 changes: 0 additions & 8 deletions src/building/how-to-build-and-run.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,8 @@ assertions = true
#
debug = true

# Number of codegen units to use for each compiler invocation. A value of 0
# means "the number of cores on this machine", and 1+ is passed through to the
# compiler.
codegen-units = 0

# Whether to always use incremental compilation when building rustc
incremental = true

# Emits extra output from tests so test failures are debuggable just from logfiles.
verbose-tests = true
```

If you have already built `rustc`, then you may have to execute `rm -rf build` for subsequent
Expand Down