Add lockfile #1829
Merged
Add lockfile #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantn
reviewed
Jun 11, 2025
|
This needs a rebase now that #1830 has landed. |
|
Rebased and recreated the lockfile. |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jun 12, 2025
Includes the following changes: * Add s390x z17 target features [1] * Remove `compiler-builtins` from `rustc-dep-of-std` dependencies [2] * Darwin AArch64 detection update [3] * Fixes for the latest nightly [4] * Add a lockfile [5] [1]: rust-lang/stdarch#1826 [2]: rust-lang/stdarch#1825 [3]: rust-lang/stdarch#1827 [4]: rust-lang/stdarch#1830 [5]: rust-lang/stdarch#1829
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2025
Update the stdarch submodule Includes the following changes: * Add s390x z17 target features [1] * Remove `compiler-builtins` from `rustc-dep-of-std` dependencies [2] * Darwin AArch64 detection update [3] * Fixes for the latest nightly [4] * Add a lockfile [5] [1]: rust-lang/stdarch#1826 [2]: rust-lang/stdarch#1825 [3]: rust-lang/stdarch#1827 [4]: rust-lang/stdarch#1830 [5]: rust-lang/stdarch#1829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to unblock rust-lang/rust#141899.
The problem is that on Rust's CI, we want to test at least compiling stdarch's
core_archand possibly run some tests (which are normally not part of stdlib). But on CI we run everything with--locked, so we need a lockfile.An alternative is to include stdarch in the stdlib's workspace. However, if I understand it correctly, stdlib only uses
std_detect, but we want to build also other crates (such ascore_arch). So we would have to include all packages from stdarch that we want to build/test on rust's CI into the stdlib workspace, which I'm not sure is a good idea (?).Happy to hear feedback!