rerunning on fixpoint change on overflow with non-trivial constraints #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lcnr opened this issue Sep 9, 2024 · 1 comment

Contributor

lcnr commented Sep 9, 2024

we do this

it's pointless as we do not apply any constraints if a goal encountered overflow.

https://github.com/rust-lang/rust/blob/1f44f0a66fa0892ca680a26e271d22993d53de5c/compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs#L401-L417

given that we now always discard overflow, we should probably just clear the query result inside of the query instead of in the caller 😅

lcnr closed this as completed

Contributor Author

lcnr commented Jan 29, 2025

changed in rust-lang/rust#130273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment