Rename ZULIP_TOKEN env var to ZULIP_WEBHOOK_SECRET #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping it backward compatible to give time to replace it in the infra.
|
@rust-lang/infra can you check this out? thanks :) |
|
I think that this will require some changes in the way we deploy triagebot, because we will need to rename the environment variable. Probably around here? I guess that we would need to synchronize merging of this PR with changing that infra config. CC @marcoieni |
|
Oh, sorry, I missed the mention of it being backwards compatible 🤦♂️ In that case I think this should be safe to merge. I will take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From comment #1989 (comment)
This patch makes it so, that we now accept
ZULIP_WEBHOOK_SECRETfor the token to send messages to Zulip, the name is slightly clearer. Keeping it compatible withZULIP_TOKENto allow time to change it in the infra.r? @Mark-Simulacrum did you mean something like this patch?
thanks